Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add account approval #108

Merged
merged 15 commits into from
Jul 17, 2023
Merged

Add account approval #108

merged 15 commits into from
Jul 17, 2023

Conversation

MerlinEgalite
Copy link
Contributor

@MerlinEgalite MerlinEgalite commented Jul 11, 2023 •
edited by Rubilmax
Loading

Rubilmax
Rubilmax reviewed Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-opening discussions

src/Blue.sol Outdated Show resolved Hide resolved
Jean-Grimal
Jean-Grimal reviewed Jul 11, 2023
View reviewed changes
src/Blue.sol Outdated Show resolved Hide resolved
Jean-Grimal
Jean-Grimal previously approved these changes Jul 11, 2023
View reviewed changes
Rubilmax
Rubilmax previously approved these changes Jul 11, 2023
View reviewed changes
QGarchery
QGarchery previously approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a new feature, we could have one test for it as well for now

@MerlinEgalite
Copy link
Contributor Author

Since this is a new feature, we could have one test for it as well for now

Yes i can

@MerlinEgalite MerlinEgalite dismissed stale reviews from QGarchery, Rubilmax, and Jean-Grimal via 209d3ea July 11, 2023 13:29
Jean-Grimal
Jean-Grimal previously approved these changes Jul 11, 2023
View reviewed changes
Jean-Grimal
Jean-Grimal previously approved these changes Jul 11, 2023
View reviewed changes
makcandrov
makcandrov previously approved these changes Jul 11, 2023
View reviewed changes
QGarchery
QGarchery previously approved these changes Jul 11, 2023
View reviewed changes
test/forge/Blue.t.sol Show resolved Hide resolved
pakim249CAL
pakim249CAL previously approved these changes Jul 13, 2023
View reviewed changes
makcandrov
makcandrov previously approved these changes Jul 13, 2023
View reviewed changes
MathisGD
MathisGD previously approved these changes Jul 13, 2023
View reviewed changes
@MerlinEgalite MerlinEgalite dismissed stale reviews from MathisGD, makcandrov, and pakim249CAL via 370e488 July 14, 2023 06:20
@MerlinEgalite MerlinEgalite mentioned this pull request Jul 17, 2023
Closed
@MerlinEgalite MerlinEgalite merged commit f6bb458 into main Jul 17, 2023
@MerlinEgalite MerlinEgalite deleted the feat/approval branch July 17, 2023 16:31
@MathisGD MathisGD mentioned this pull request Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makcandrov makcandrov makcandrov approved these changes

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@MathisGD MathisGD MathisGD approved these changes

@pakim249CAL pakim249CAL pakim249CAL approved these changes

@QGarchery QGarchery QGarchery approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Account Management
7 participants
@MerlinEgalite @Rubilmax @QGarchery @pakim249CAL @MathisGD @Jean-Grimal @makcandrov