fixes after review #121 (authorization with signature) #192

MathisGD · 2023-07-28T08:25:23Z

Fixes:

src/Blue.sol

MerlinEgalite

#123

src/Blue.sol

MerlinEgalite

Did you check my comment here, @MathisGD ? We should be sure before merging this PR.

src/Blue.sol

test/forge/Blue.t.sol

src/libraries/Errors.sol

Rubilmax · 2023-07-31T08:54:54Z

src/Blue.sol

@@ -77,18 +67,17 @@ contract Blue is IFlashLender {
    mapping(IIrm => bool) public isIrmEnabled;
    // Enabled LLTVs.
    mapping(uint256 => bool) public isLltvEnabled;
-    // User's managers.
-    mapping(address => mapping(address => bool)) public isApproved;
+    // User's authorizations. Note that by default, msg.sender is authorized by themself.


Suggested change

// User's authorizations. Note that by default, msg.sender is authorized by themself.

// User's authorizations. Note that by default, msg.sender is authorized by themselves.

Perhaps am I mistaken and happy to learn, I invoke the guru @pakim249CAL

src/Blue.sol

MathisGD added 2 commits July 28, 2023 10:27

style: approve with sig

96a8f28

perf: remove nonce from args

0872299

MathisGD force-pushed the feat/approval-with-sig-1 branch from 493e444 to 0872299 Compare July 28, 2023 08:29

MathisGD added 3 commits July 28, 2023 10:31

style: signature error wording

0961afa

style: immutable case

7e58d62

style: harmonize authorizations naming

391ab28

MathisGD requested a review from MerlinEgalite July 28, 2023 08:55

MathisGD marked this pull request as ready for review July 28, 2023 08:55

MathisGD self-assigned this Jul 28, 2023

MathisGD mentioned this pull request Jul 28, 2023

Add authorization with signature #114

Merged

perf: remove redondant checks on sig

fe70678

MathisGD force-pushed the feat/approval-with-sig-1 branch from 970846d to fe70678 Compare July 28, 2023 09:26

MerlinEgalite requested changes Jul 28, 2023

View reviewed changes

src/Blue.sol Outdated Show resolved Hide resolved

src/Blue.sol Outdated Show resolved Hide resolved

src/Blue.sol Show resolved Hide resolved

src/Blue.sol Outdated Show resolved Hide resolved

src/Blue.sol Show resolved Hide resolved

style: fixes after review

6ce91a5

MerlinEgalite requested changes Jul 28, 2023

View reviewed changes

fix: readd name in domain

40a3855

MathisGD commented Jul 28, 2023

View reviewed changes

src/Blue.sol Show resolved Hide resolved

fix: check that signatory is not address zero

7ed0975

MathisGD requested a review from MerlinEgalite July 28, 2023 10:18

MerlinEgalite reviewed Jul 29, 2023

View reviewed changes

Rubilmax reviewed Jul 31, 2023

View reviewed changes

src/Blue.sol Outdated Show resolved Hide resolved

src/Blue.sol Show resolved Hide resolved

Rubilmax reviewed Jul 31, 2023

View reviewed changes

test/forge/Blue.t.sol Outdated Show resolved Hide resolved

src/libraries/Errors.sol Outdated Show resolved Hide resolved

style: errors wording and tests

af2d66f

MathisGD changed the title ~~fixes after review #121 (approval with signature)~~ fixes after review #121 (authorization with signature) Jul 31, 2023

MathisGD linked an issue Jul 31, 2023 that may be closed by this pull request

isApproved helper function naming #139

Closed

style: sender is authorized by default

541c883

MathisGD mentioned this pull request Jul 31, 2023

isApproved helper function naming #139

Closed

MathisGD requested review from MerlinEgalite and Rubilmax July 31, 2023 08:52

Rubilmax approved these changes Jul 31, 2023

View reviewed changes

style: isSenderApproved function naming

f45f4d5

MerlinEgalite merged commit d5c8b13 into feat/approval-with-sig Jul 31, 2023

MerlinEgalite deleted the feat/approval-with-sig-1 branch July 31, 2023 11:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes after review #121 (authorization with signature) #192

fixes after review #121 (authorization with signature) #192

MathisGD commented Jul 28, 2023 •

edited

Loading

MerlinEgalite left a comment

MerlinEgalite left a comment

Rubilmax Jul 31, 2023

	// User's authorizations. Note that by default, msg.sender is authorized by themself.
	// User's authorizations. Note that by default, msg.sender is authorized by themselves.

fixes after review #121 (authorization with signature) #192

fixes after review #121 (authorization with signature) #192

Conversation

MathisGD commented Jul 28, 2023 • edited Loading

MerlinEgalite left a comment

Choose a reason for hiding this comment

MerlinEgalite left a comment

Choose a reason for hiding this comment

Rubilmax Jul 31, 2023

Choose a reason for hiding this comment

MathisGD commented Jul 28, 2023 •

edited

Loading