Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: transferOwnership -> setOwner #196

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Refactor: transferOwnership -> setOwner #196

merged 1 commit into from
Jul 31, 2023

Conversation

MerlinEgalite
Copy link
Contributor

Fixes #195

@MerlinEgalite MerlinEgalite changed the title Refactor: transferOwnership -> setOwner Refactor: transferOwnership -> setOwner Jul 29, 2023
@pakim249CAL
Copy link
Contributor

Do we not wish to comply with a standard Ownable interface?

@MathisGD
Copy link
Contributor

I think that we were already not completely compliant (renounceOwnership()) so I don't think that it's an issue.

@MathisGD MathisGD merged commit bd7b66e into main Jul 31, 2023
@MathisGD MathisGD deleted the refactor/owner branch July 31, 2023 08:35
@makcandrov makcandrov mentioned this pull request Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makcandrov makcandrov makcandrov approved these changes

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@MathisGD MathisGD MathisGD approved these changes

@pakim249CAL pakim249CAL pakim249CAL approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

@QGarchery QGarchery Awaiting requested review from QGarchery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

transferOwnership -> setOwner for consistency
6 participants
@MerlinEgalite @pakim249CAL @MathisGD @Rubilmax @Jean-Grimal @makcandrov