-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove flashloan receiver #207
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
previously approved these changes
Aug 1, 2023
Features lost with this change:
|
MathisGD
requested review from
MerlinEgalite,
pakim249CAL,
Jean-Grimal,
makcandrov and
Rubilmax
August 1, 2023 22:10
makcandrov
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I totally agree with the idea of harmonizing the callbacks. But imo the flashloan receiver could have been useful
Rubilmax
previously approved these changes
Aug 2, 2023
MerlinEgalite
previously approved these changes
Aug 2, 2023
Jean-Grimal
previously approved these changes
Aug 2, 2023
makcandrov
suggested changes
Aug 2, 2023
MathisGD
dismissed stale reviews from Jean-Grimal, MerlinEgalite, and Rubilmax
via
August 2, 2023 13:24
d5498db
MathisGD
requested review from
MerlinEgalite,
Rubilmax,
makcandrov and
Jean-Grimal
August 2, 2023 13:24
makcandrov
previously approved these changes
Aug 2, 2023
MerlinEgalite
previously approved these changes
Aug 2, 2023
Rubilmax
previously approved these changes
Aug 2, 2023
MathisGD
dismissed stale reviews from Rubilmax, MerlinEgalite, and makcandrov
via
August 2, 2023 13:47
c351c66
Jean-Grimal
approved these changes
Aug 2, 2023
makcandrov
approved these changes
Aug 2, 2023
Rubilmax
approved these changes
Aug 2, 2023
pakim249CAL
approved these changes
Aug 2, 2023
MerlinEgalite
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for doing this:
NB: an arbitrary
from
intransferFrom
is a critical issue for slither.