feat: compound interest #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakim249CAL
requested review from
Rubilmax,
QGarchery,
MerlinEgalite,
MathisGD,
Jean-Grimal and
makcandrov
Rubilmax
previously approved these changes
Aug 4, 2023
Co-authored-by: Romain Milon <rmilon@gmail.com> Signed-off-by: Patrick Kim <patrick@morpho.xyz>
Rubilmax
previously approved these changes
Aug 4, 2023
Jean-Grimal
previously approved these changes
Aug 4, 2023
Jean-Grimal
previously approved these changes
Aug 4, 2023
MerlinEgalite
previously approved these changes
Aug 4, 2023
Rubilmax
previously approved these changes
Aug 4, 2023
makcandrov
suggested changes
Aug 5, 2023
pakim249CAL
dismissed stale reviews from Rubilmax, MerlinEgalite, and Jean-Grimal
via
a464d94
Co-authored-by: makcandrov <makcandrov@proton.me> Signed-off-by: Patrick Kim <patrick@morpho.xyz>
Rubilmax
previously approved these changes
Aug 5, 2023
Jean-Grimal
previously approved these changes
Aug 7, 2023
Jean-Grimal
reviewed
Aug 9, 2023
MerlinEgalite
previously approved these changes
Aug 9, 2023
MerlinEgalite
previously approved these changes
Aug 9, 2023
Jean-Grimal
previously approved these changes
Aug 9, 2023
makcandrov
previously approved these changes
Aug 9, 2023
pakim249CAL
dismissed stale reviews from makcandrov, Jean-Grimal, and MerlinEgalite
via
1e74522
makcandrov
approved these changes
Aug 9, 2023
Rubilmax
approved these changes
Aug 9, 2023
|
Should we compound continuously ? |
MerlinEgalite
approved these changes
Aug 9, 2023
So basically the proposal is to remove the zero floor subs to transform the compounding from every second to continuous compounding, correct? I would welcome that idea in another future PR. |
Jean-Grimal
approved these changes
Aug 9, 2023
QGarchery
approved these changes
Aug 9, 2023
MathisGD
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81
A redone version of #135