Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(set-fee): accrue interests before changing fee #243

Merged
merged 1 commit into from
Aug 9, 2023
Merged

fix(set-fee): accrue interests before changing fee #243

merged 1 commit into from
Aug 9, 2023

Conversation

Rubilmax
Copy link
Collaborator

@Rubilmax Rubilmax commented Aug 8, 2023

@Rubilmax Rubilmax requested review from a team, MerlinEgalite, pakim249CAL, Jean-Grimal, makcandrov, QGarchery and MathisGD and removed request for a team August 8, 2023 16:31
@Rubilmax Rubilmax marked this pull request as ready for review August 8, 2023 16:31
MerlinEgalite
MerlinEgalite approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test @makcandrov @Jean-Grimal please?

@MathisGD
Copy link
Contributor

MathisGD commented Aug 8, 2023

Can you add a test @makcandrov @Jean-Grimal please?

@Rubilmax can probably do it too, it's literally one line to add in the setFee test

@pakim249CAL
Copy link
Contributor

Can you add a test @makcandrov @Jean-Grimal please?

@Rubilmax can probably do it too, it's literally one line to add in the setFee test

I don't think it's necessary. We should just add a line to the BTT and do the test in the big testing refactor IMO

@MathisGD
Copy link
Contributor

MathisGD commented Aug 8, 2023

Yes I'm also ok to merge without changes

@MathisGD MathisGD merged commit b899622 into main Aug 9, 2023
@MathisGD MathisGD deleted the fix/fee-accrue-interests branch August 9, 2023 08:17
@Rubilmax Rubilmax mentioned this pull request Aug 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makcandrov makcandrov makcandrov approved these changes

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@MathisGD MathisGD MathisGD approved these changes

@pakim249CAL pakim249CAL pakim249CAL approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@QGarchery QGarchery QGarchery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we add the supplyRate to the AccrueInterests event?
7 participants
@Rubilmax @MathisGD @pakim249CAL @QGarchery @MerlinEgalite @Jean-Grimal @makcandrov