Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pure function for to get the id of a market #32

Merged
merged 4 commits into from
Jul 5, 2023
Merged

Use pure function for to get the id of a market #32

merged 4 commits into from
Jul 5, 2023

Conversation

MerlinEgalite
Copy link
Contributor

I know it's adding lines of code but IMO it's much more readable using this.

QGarchery
QGarchery requested changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍

src/Market.sol Outdated Show resolved Hide resolved
src/Market.sol Outdated Show resolved Hide resolved
MathisGD
MathisGD approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool stuff !

@MathisGD MathisGD merged commit 3bf3db0 into dev Jul 5, 2023
@MathisGD MathisGD deleted the refactor/to-id branch July 5, 2023 09:43
@MathisGD MathisGD mentioned this pull request Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathisGD MathisGD MathisGD approved these changes

@QGarchery QGarchery QGarchery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MerlinEgalite @QGarchery @MathisGD