feat: add fee #63
feat: add fee #63
Conversation
pakim249CAL
requested review from
Rubilmax,
QGarchery,
MerlinEgalite,
MathisGD and
makcandrov
|
@pakim249CAL can you continue this PR? |
|
Can we make it a per market fee @pakim249CAL ? |
| @@ -78,6 +79,11 @@ contract Blue { | |||
| owner = newOwner; | |||
| } | |||
|
|
|||
| function setFee(MarketParams calldata marketParams, uint fee) external onlyOwner { | |||
| require(fee <= WAD, "fee must be <= 1"); | |||
| _marketStorage[marketParams.toId()].market.fee = fee; | |||
There was a problem hiding this comment.
It does not cost much to check that the market where we change the fee exists (since this is an admin function)
There was a problem hiding this comment.
May have been enforced via a private or internal getter :D
There was a problem hiding this comment.
Agreed, this is what I proposed here. It has been closed because input validation is pretty minimal right now, only 2 things to check that are not related: the id corresponds to an existing market, the amount is non zero. I'm ok with either solution
There was a problem hiding this comment.
The fee should be capped, just created an issue for that #110
| @@ -78,6 +79,11 @@ contract Blue { | |||
| owner = newOwner; | |||
| } | |||
|
|
|||
| function setFee(MarketParams calldata marketParams, uint fee) external onlyOwner { | |||
| require(fee <= WAD, "fee must be <= 1"); | |||
| _marketStorage[marketParams.toId()].market.fee = fee; | |||
There was a problem hiding this comment.
The fee should be capped, just created an issue for that #110
| @@ -296,6 +302,12 @@ contract Blue { | |||
| uint256 accruedInterests = marketTotalBorrow.wMul(borrowRate).wMul(block.timestamp - m.lastUpdate); | |||
| m.totalSupply = marketTotalSupply + accruedInterests; | |||
| m.totalBorrow = marketTotalBorrow + accruedInterests; | |||
| if (m.fee != 0) { | |||
There was a problem hiding this comment.
| if (m.fee != 0) { | |
| if (m.fee != 0) { |
Let's make the code breath a bit
| @@ -296,6 +302,12 @@ contract Blue { | |||
| uint256 accruedInterests = marketTotalBorrow.wMul(borrowRate).wMul(block.timestamp - m.lastUpdate); | |||
| m.totalSupply = marketTotalSupply + accruedInterests; | |||
| m.totalBorrow = marketTotalBorrow + accruedInterests; | |||
| if (m.fee != 0) { | |||
| uint256 fee = accruedInterests.wMul(m.fee); | |||
| uint256 feeShares = fee.wMul(m.totalSupplyShares).wDiv(m.totalSupply - fee); | |||
There was a problem hiding this comment.
should we explain the reasoning of the "-"?
pakim249CAL
dismissed stale reviews from Rubilmax, QGarchery, and makcandrov
The base branch was changed.
|
Redone here on main #116 |
Fixes #62
Just contains minimal fee logic for a global fee with a global fee recipient. We can expand on this in future PRs.