fix(authorization): revert already set error

[Rubilmax]

• Fixes various fixes #630 (comment)

[QGarchery]

Should also remove the corresponding test, but otherwise LGTM

[MerlinEgalite]

we don't delete it for setAuthorization? I feel this is useless as well and a bit weird to have 2 different requirements for the same functionality

[Rubilmax]

we don't delete it for setAuthorization? I feel this is useless as well and a bit weird to have 2 different requirements for the same functionality

This argument can also be used to defend the introduction of such requirement: why would we require not already set fee but not in setAuthorization* functions?

In the end, I am convinced we were inconsistent, though I am not convinced it is a big deal...

[MerlinEgalite]

But now we're being weirdly inconsistent it's even more disturbing to me

[Rubilmax]

But now we're being weirdly inconsistent it's even more disturbing to me

Mb I wasn't clear: I was arguing we shouldn't revert the change at all!

[Rubilmax]

Another rationale behind this PR would be to simply revert the changes to the old way, even if it can be considered inconsistent, because it still works and there's no big deal

[QGarchery]

why would we require not already set fee but not in setAuthorization* functions?

For setAuthorizationWithSig it's because the function is inherently more complicated and signatures are asynchronous by nature. I don't feel like just because it looks disturbing it means that it is incorrect.

You can also look at it another way: we are never in the "already set" case for setAuthorizationWithSig because it's at least changing the nonce. If we really want to be consistent, we could change INVALID_NONCE into ALREADY_SET (but I don't feel like it's necessary)

[Rubilmax]

LGTM

[MerlinEgalite]

Let's add a comment no?

[Rubilmax]

Let's add a comment no?

Something like:
/// Do not check whether authorization is already set because the nonce increment is a desired side-effect.

[MerlinEgalite]

Let's add a comment no?

Something like: /// Do not check whether authorization is already set because the nonce increment is a desired side-effect.

LGTM