Feat: owner (alternative) #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Rubilmax
reviewed
Jul 6, 2023
There was a problem hiding this comment.
This alterantive has the same drawbacks than highlighted in #43 (comment).
I am against such an implementation.
|
@MerlinEgalite @QGarchery thoughts ? |
|
Reasons why I prefer this version:
|
|
Both are pretty short and easy to understand, but if I had to choose I'd go for this version. It has the advantage of keeping the storage at the same place, and we don't get much by regrouping the functionalities in this case |
|
I don't have a strong opinion on this. I can update my PR or @MathisGD you can update yours and I'll need to update the base of the PRs on top of mine |
|
Closed in favor of #43, which in the end does the same thing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #43, included in the contract.