Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimate gas cost of liquidations #7

Merged
merged 19 commits into from
Jul 10, 2023
Merged

Conversation

QGarchery
Copy link
Contributor

@QGarchery QGarchery commented Jun 28, 2023

@QGarchery QGarchery self-assigned this Jun 28, 2023
@QGarchery QGarchery changed the title feat: estimate gas cost of batch liquidation Estimate gas cost liquidations Jun 28, 2023
@QGarchery QGarchery changed the title Estimate gas cost liquidations Estimate gas cost of liquidations Jun 28, 2023
@MathisGD
Copy link
Contributor

MathisGD commented Jul 4, 2023

Requires the rebasing of #4 but I'm in favor of adding hardhat gas tests for liquidations (it should not delete the previous gas tests though).

test/hardhat/Market.spec.ts Outdated Show resolved Hide resolved
test/hardhat/Market.spec.ts Outdated Show resolved Hide resolved
test/hardhat/Market.spec.ts Outdated Show resolved Hide resolved
test/hardhat/Market.spec.ts Outdated Show resolved Hide resolved
src/mocks/LiquidatorMock.sol Outdated Show resolved Hide resolved
test/hardhat/Market.spec.ts Outdated Show resolved Hide resolved
test/hardhat/Market.spec.ts Outdated Show resolved Hide resolved
test/hardhat/Market.spec.ts Outdated Show resolved Hide resolved
test/hardhat/Market.spec.ts Outdated Show resolved Hide resolved
@QGarchery QGarchery marked this pull request as ready for review July 4, 2023 15:55
Base automatically changed from feat/liquidation to dev July 5, 2023 08:47
test/hardhat/Blue.spec.ts Outdated Show resolved Hide resolved
test/hardhat/Blue.spec.ts Show resolved Hide resolved
test/hardhat/Blue.spec.ts Outdated Show resolved Hide resolved
test/hardhat/Blue.spec.ts Show resolved Hide resolved
test/hardhat/Blue.spec.ts Outdated Show resolved Hide resolved
@QGarchery QGarchery dismissed stale reviews from Rubilmax and MathisGD via d6f6f2a July 7, 2023 13:51
@QGarchery QGarchery requested review from Rubilmax and MathisGD July 7, 2023 13:55
test/hardhat/Blue.spec.ts Outdated Show resolved Hide resolved
Rubilmax
Rubilmax previously approved these changes Jul 7, 2023
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe should be consistent with lltv naming in the contracts

@QGarchery QGarchery changed the base branch from dev to feat/enable-lltv July 8, 2023 19:27
@QGarchery
Copy link
Contributor Author

Maybe should be consistent with lltv naming in the contracts

Changed the base to #73 so we don't do the changes twice

@QGarchery QGarchery mentioned this pull request Jul 8, 2023
MerlinEgalite
MerlinEgalite previously approved these changes Jul 9, 2023
MathisGD
MathisGD previously approved these changes Jul 10, 2023
@MathisGD
Copy link
Contributor

I suggest that we don't merge it into #73 and wait for it to be merged

Base automatically changed from feat/enable-lltv to dev July 10, 2023 09:35
@MerlinEgalite MerlinEgalite dismissed stale reviews from MathisGD and themself July 10, 2023 09:35

The base branch was changed.

@QGarchery QGarchery merged commit 0a1b22c into dev Jul 10, 2023
@QGarchery QGarchery deleted the test/estimate-liquidation-gas branch July 10, 2023 10:47
@QGarchery QGarchery mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants