Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak Application#builds and add #custom_fields #3

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Tweak Application#builds and add #custom_fields #3

merged 3 commits into from
Jul 12, 2022

Conversation

aogail
Copy link
Contributor

@aogail aogail commented Nov 25, 2019

Thanks for the veracode-api gem. This PR includes two changes:

  • Fix Application#builds handling of the case when the application returned by the API has no build attribute.
  • Add a #custom_fields method that returns the custom fields set for the application.

mort666
mort666 approved these changes Jul 12, 2022
View reviewed changes
Copy link
Owner

@mort666 mort666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good..

@mort666
Copy link
Owner

mort666 commented Jul 12, 2022

Thanks for the PR, have looked it over will merge..

@mort666 mort666 merged commit 98424c6 into mort666:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mort666 mort666 mort666 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aogail @mort666