Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where $ is undefined. #1

Closed
wants to merge 1 commit into from
Closed

Fix bug where $ is undefined. #1

wants to merge 1 commit into from

Conversation

mortenson
Copy link
Owner

$ is not always globally available on my site, so we should use the global jQuery if it is available.

@WidgetsBurritos
Copy link

A safety mechanism to protect against this is to never accept PR changes for anything in dist/. We only ever update our dist during version bumps.

@mortenson
Copy link
Owner Author

@WidgetsBurritos Once I have more examples I should probably make a mitigations section of the README.

@WidgetsBurritos
Copy link

@mortenson cool. I'll keep an eye out

@mortenson mortenson closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants