Add support for Drop artifact to Publish and Download build artifacts… #2
Conversation
| manifestid: artifact.resource.data | ||
| }; | ||
|
|
||
| tl.command("artifact.download", properties, downloadPath); |
There was a problem hiding this comment.
Note, we should not add this command permanently. When this command is used, I would have the command handler check the currently running task and verify the ID is your task otherwise fail. Customers should not be able to use this in their ad hoc scripts. Fire and forget command doesn't make sense for download, from user scripts.
There was a problem hiding this comment.
should be just switch the entire drop download into C# when GA?
| "version": { | ||
| "Major": 1, | ||
| "Minor": 131, | ||
| "Major": 2, |
There was a problem hiding this comment.
we should take this opportunity to rename the task "PublishDropArtifact" since this should work in the future from a release as well
| "Major": 1, | ||
| "Minor": 131, | ||
| "Major": 2, | ||
| "Minor": 0, |
| @@ -68,7 +68,7 @@ async function run() { | |||
|
|
|||
| // upload or copy | |||
| if (artifactType === "container") { | |||
There was a problem hiding this comment.
I think this is a good opportunity to rename the task value for "Visual Studio Team Services/TFS" to server or possibly drop. I know we don't have to, but continuing to have container in the build definition will be confusing.
As far as people switching from v1 to v2: We're allowed to make breaking changes in new major versions, but we could check if (artifactType === "filepath") { first and handle other values (server or container) in the else clause.
| "Major": 1, | ||
| "Minor": 131, | ||
| "Major": 2, | ||
| "Minor": 0, | ||
| "Patch": 0 | ||
| }, | ||
| "demands": [], |
There was a problem hiding this comment.
Add preview and releaseNotes. Example from Xcode's task.json:
"preview": true,
"releaseNotes": "This version of the task is compatible with Xcode 8 and Xcode 9. Features that were there solely to maintain compat with Xcode 7 have been removed. The task has better options to work with the Hosted macOS pool.",
| manifestid: artifact.resource.data | ||
| }; | ||
|
|
||
| tl.command("artifact.download", properties, downloadPath); |
There was a problem hiding this comment.
Does console.log(tl.loc('ArtifactsSuccessfullyDownloaded', downloadPath)); below the diff execute before the artifact is downloaded? Not sure if there's a way to monitor completion/success.
There was a problem hiding this comment.
that's why artifact.download needs to be removed
… tasks