Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating FSDP monkeypatch #2571

Merged
merged 13 commits into from
Sep 27, 2023
Merged

Updating FSDP monkeypatch #2571

merged 13 commits into from
Sep 27, 2023

Conversation

mvpatel2000
Copy link
Contributor

@mvpatel2000 mvpatel2000 commented Sep 27, 2023 •
edited
Loading

What does this PR do?

Changes monkeypatch to fix _or_policy and also fix a typo in monkeypatch.

@mvpatel2000 mvpatel2000 changed the title [WIP] Updating monkeypatch Updating FSDP monkeypatch Sep 27, 2023
@mvpatel2000 mvpatel2000 requested a review from b-chu September 27, 2023 21:05
@mvpatel2000 mvpatel2000 requested a review from vchiley September 27, 2023 21:25
vchiley
vchiley approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@vchiley vchiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mvpatel2000 mvpatel2000 merged commit d56d4ad into mosaicml:dev Sep 27, 2023
17 checks passed
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/debug-wrap-finalkwargs branch September 27, 2023 21:52
@mvpatel2000 mvpatel2000 restored the mvpatel2000/debug-wrap-finalkwargs branch September 27, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchiley vchiley vchiley approved these changes

@b-chu b-chu Awaiting requested review from b-chu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvpatel2000 @vchiley