Remove monkeypatch and new state dict APIs for torch 2.2 #2899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dskhudia
reviewed
Jan 24, 2024
dskhudia
approved these changes
Jan 24, 2024
linden-li
approved these changes
Jan 24, 2024
|
Why not do >= 2.3.0? |
Nightly versioning makes it weird. I've seen that kind of check fail :( |
ShashankMosaicML
pushed a commit
to ShashankMosaicML/composer
that referenced
this pull request
Feb 3, 2024
* fix mosaicfsdp * bump to 2.3 * remove init
ShashankMosaicML
pushed a commit
to ShashankMosaicML/composer
that referenced
this pull request
Feb 3, 2024
* fix mosaicfsdp * bump to 2.3 * remove init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove monkeypatch and new state dict APIs (which also always require dist init) for torch 2.2. We will delay to 2.3.