Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
test_mlflow_ignore_hyperparameters
is flakey--it passed tests on PR submission but later failed:This test was copied almost directly from
test_mlflow_logging_works
with a few commands removed because they were thought to be unnecessary (and some changes made for ignoring some hyperparameters).The suspected culprit is the removal of the sleep. This small pause gave time for async logging to finish, and this test would nondeterministically fail because we didn't let it finish up logging (missing parameters that should be there).
What issue(s) does this change relate to?
Before submitting
pre-commit
on your change? (see thepre-commit
section of prerequisites)