Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit None Check in get_device #3586

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Explicit None Check in get_device #3586

merged 1 commit into from
Aug 29, 2024

Conversation

mvpatel2000
Copy link
Contributor

What does this PR do?

Explicit None Check in get_device

snarayan21
snarayan21 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i mean, functionally the same, but is more explicit yea

@mvpatel2000 mvpatel2000 merged commit eda41dc into mosaicml:main Aug 29, 2024
14 checks passed
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/none-check branch August 29, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snarayan21 snarayan21 snarayan21 approved these changes

@b-chu b-chu Awaiting requested review from b-chu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvpatel2000 @snarayan21