Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ubuntu 22.04 + fix CI mlflow tests #3716

Merged
merged 20 commits into from
Nov 19, 2024
Merged

Bump ubuntu 22.04 + fix CI mlflow tests #3716

merged 20 commits into from
Nov 19, 2024

Conversation

KuuCi
Copy link
Contributor

@KuuCi KuuCi commented Nov 19, 2024

What does this PR do?

Bump to Ubuntu 22.04, 20.04 will be EOLed in 5 months. Main caveat is that Ubuntu 22.04 apt installs blinker, which cannot be pip uninstalled, meaning that build will error when composer tries to update the version, so we need to apt uninstall and install via pip.

Also Mlflow changed how they default their tracking_uri, so fix for that here where we just manually set the properly tracking_uri in test fixtures

What issue(s) does this change relate to?

https://databricks.atlassian.net/browse/GRT-3195

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@KuuCi KuuCi requested a review from a team as a code owner November 19, 2024 15:38
@KuuCi KuuCi force-pushed the bump-ubuntu-22.04 branch from 87f02c8 to 88aeec3 Compare November 19, 2024 15:53
@KuuCi KuuCi force-pushed the bump-ubuntu-22.04 branch from 356e530 to 8ac5db8 Compare November 19, 2024 20:35
@KuuCi KuuCi changed the title Bump ubuntu 22.04 Bump ubuntu 22.04 + fix CI mlflow tests Nov 19, 2024
@KuuCi KuuCi merged commit 890d9ee into main Nov 19, 2024
26 checks passed
@KuuCi KuuCi deleted the bump-ubuntu-22.04 branch November 19, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants