Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix daily test failures #3733

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Fix daily test failures #3733

merged 1 commit into from
Dec 3, 2024
+4 −4

Conversation

snarayan21
Copy link
Contributor

@snarayan21 snarayan21 commented Dec 3, 2024 •
edited
Loading

What does this PR do?

Daily tests were previously failing due to a few changes from PR #3727

This PR fixes that. Successful daily tests: https://github.com/mosaicml/composer/actions/runs/12147980170/job/33875436037

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@snarayan21 snarayan21 marked this pull request as draft December 3, 2024 20:57
@snarayan21 snarayan21 marked this pull request as ready for review December 3, 2024 21:36
@snarayan21 snarayan21 merged commit 56df00f into main Dec 3, 2024
34 checks passed
@snarayan21 snarayan21 deleted the saaketh/daily_fix_dec branch December 3, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

@bigning bigning Awaiting requested review from bigning

@j316chuck j316chuck Awaiting requested review from j316chuck

@b-chu b-chu Awaiting requested review from b-chu

@dakinggg dakinggg Awaiting requested review from dakinggg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snarayan21 @mvpatel2000