Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LoadPlanner and SavePlanner registries #1358

Merged
merged 13 commits into from
Jul 18, 2024

Conversation

irenedea
Copy link
Contributor

@irenedea irenedea commented Jul 13, 2024

Enables users to add custom logic to checkpoint loading or saving.

Testing

load-save-planner-test-EyE9Kq

Tested off of commit 9b6e1bc that adds custom load and save planners.

@irenedea irenedea force-pushed the load-save-planner branch 2 times, most recently from 2ad88da to 35678a9 Compare July 15, 2024 23:09
@irenedea irenedea marked this pull request as ready for review July 15, 2024 23:09
@irenedea irenedea requested a review from a team as a code owner July 15, 2024 23:09
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, other than that lgtm

llmfoundry/registry.py Show resolved Hide resolved
@irenedea irenedea requested a review from dakinggg July 16, 2024 00:19
llmfoundry/registry.py Show resolved Hide resolved
llmfoundry/utils/builders.py Outdated Show resolved Hide resolved
llmfoundry/utils/builders.py Outdated Show resolved Hide resolved
llmfoundry/registry.py Show resolved Hide resolved
@irenedea irenedea enabled auto-merge (squash) July 16, 2024 22:07
@irenedea irenedea merged commit acb5530 into mosaicml:main Jul 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants