Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow flash attention up to 3 #1377

Merged
merged 2 commits into from
Jul 20, 2024
Merged

Allow flash attention up to 3 #1377

merged 2 commits into from
Jul 20, 2024

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Jul 19, 2024

Allows flash attention version up to 3 to make the docker image/install version correspondence less brittle (i.e. if we bump the flash attention version in the docker image to 2.6, the foundry install won't instantly break)

@dakinggg dakinggg requested a review from a team as a code owner July 19, 2024 22:45
Copy link
Contributor

@bigning bigning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Contributor

@vchiley vchiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dakinggg dakinggg enabled auto-merge (squash) July 20, 2024 22:44
@dakinggg dakinggg merged commit d50b0db into main Jul 20, 2024
9 checks passed
@dakinggg dakinggg deleted the dakinggg-patch-5 branch August 6, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants