Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Simulator! #385

Merged
merged 40 commits into from
Nov 2, 2023
Merged

The Simulator! #385

merged 40 commits into from
Nov 2, 2023

Conversation

snarayan21
Copy link
Collaborator

@snarayan21 snarayan21 commented Aug 17, 2023

Description of changes:

Adding a simulator for streaming. New features added:

  • handles multiple streams and the associated params
  • supports all features of StreamingDataset
  • parsing MosaicML training yaml files of all types currently in use
  • shuffle quality analysis
  • cache limit analysis
    Further information about the features of the simulator are in the readme file at streaming/simulation.

This new series of commits also includes an extensive refactoring of the code to make it more modular, understandable, and extensible down the road. Typing and docstrings are also added.

Issue #, if available:

Simulator story: https://mosaicml.atlassian.net/browse/STR-123

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

setup.py Show resolved Hide resolved
simulation/core/create_index.py Outdated Show resolved Hide resolved
simulation/core/create_index.py Outdated Show resolved Hide resolved
simulation/core/create_index.py Show resolved Hide resolved
simulation/core/create_index.py Outdated Show resolved Hide resolved
simulation/core/create_index.py Outdated Show resolved Hide resolved
simulation/core/create_index.py Outdated Show resolved Hide resolved
simulation/core/create_index.py Outdated Show resolved Hide resolved
simulation/core/create_index.py Outdated Show resolved Hide resolved
simulation/core/main.py Show resolved Hide resolved
simulation/core/node_tracker.py Outdated Show resolved Hide resolved
simulation/core/node_tracker.py Show resolved Hide resolved
simulation/core/node_tracker.py Show resolved Hide resolved
simulation/core/shuffle_quality.py Outdated Show resolved Hide resolved
simulation/core/sim_time.py Outdated Show resolved Hide resolved
simulation/requirements.txt Outdated Show resolved Hide resolved
simulation/interfaces/widgets.py Outdated Show resolved Hide resolved
simulation/interfaces/sim_ui.py Outdated Show resolved Hide resolved
simulation/interfaces/sim_ui.py Outdated Show resolved Hide resolved
simulation/interfaces/sim_ui.py Show resolved Hide resolved
simulation/core/yaml_processing.py Outdated Show resolved Hide resolved
simulation/README.md Show resolved Hide resolved
Copy link
Collaborator

@karan6181 karan6181 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank You!

@snarayan21 snarayan21 merged commit a94476b into mosaicml:main Nov 2, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants