add acl tests #47
Merged
add acl tests #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosajjal
added a commit
that referenced
this pull request
May 13, 2023
* v2 mvp * minor changes and fixes * fixed the timer on geoip, added loglevel * added cidr acl * Update install.sh * minor yq fixes * better acl docs and var names * allow individual binds for different services * added ability to generate default config yaml * clearer parameters in geoip configs * cleaner installer wizard * added version info in build * removed extra whitespace * ACL overhaul * tweaked release parameters * converted defaultconfig to boolean * removed unused doh client * doh fixes * change override log to debug * doq connects back to the correct upstream * bugfixes in dns and ACL * moved back to zerolog and pretty logging * more fixes in logging format * fix in debug logging of DoQ * minor changes in cidr acl logic * add acl tests (#47) * add acl tests * moved yaml configs to the test file * added back previous tests and fixed the run function --------- Co-authored-by: Ali Mosajjal <hi@n0p.me> * acl stringifier * minor docs changes in the install.sh script --------- Co-authored-by: Andreas Groll <10852221+holygrolli@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds (basic) tests to the ACLs. I have limited Golang skills, did my best.
This confirms the last commit b20546a made the ACL decisions work as expected.