Fix #211 #212
Merged
Fix #211 #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 6, 2018 20:49
|
I don't think this failure is because of my changes. Could you restart the Travis CI? |
| id: that.id, | ||
| brokerId: that.broker.id | ||
| }, nop) | ||
| } | ||
| } | ||
| }) | ||
| that.will = null // this function might be called twice |
There was a problem hiding this comment.
Huhm! authorizePublish is async function. Server will crash when that.broker.publish(that.will, that, done) called because that.will is null
|
Correct, `that.will` should be replaced by a local copy.
Met vriendelijke groet,
Martijn Verbakel
… @nguyenthenguyen commented on this pull request.
In lib/client.js:
> - that.broker.persistence.delWill({
- id: that.id,
- brokerId: that.broker.id
- }, nop)
+ that.broker.publish(that.will, that, done)
+ } else {
+ done()
+ }
+
+ function done (err) {
+ if (!err) {
+ that.broker.persistence.delWill({
+ id: that.id,
+ brokerId: that.broker.id
+ }, nop)
+ }
}
})
that.will = null // this function might be called twice
Huhm! authorizePublish is async function. Server will crash when that.broker.publish(that.will, that, done) called because that.will is null
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@mhverbakel I have make a pull request #213 |
|
@mhverbakel @mcollina Should we authorization will package when client connect? |
|
I thought so too, but @mcollina thinks it should be on send (#211 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.