Skip to content

Commit

Permalink
Merge pull request apache#23603: Keep Spark version in a single place…
Browse files Browse the repository at this point in the history
… only (BeamModulePlugin)
  • Loading branch information
aromanenko-dev authored Oct 19, 2022
2 parents b5a0f48 + 7b6cc89 commit 1179fdc
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,10 @@ class BeamModulePlugin implements Plugin<Project> {
def arrow_version = "5.0.0"
def jmh_version = "1.34"

// Export Spark versions, so they are defined in a single place only
project.ext.spark2_version = spark2_version
project.ext.spark3_version = spark3_version

// A map of maps containing common libraries used per language. To use:
// dependencies {
// compile library.java.slf4j_api
Expand Down
4 changes: 2 additions & 2 deletions runners/spark/2/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
def basePath = '..'
/* All properties required for loading the Spark build script */
project.ext {
// Set the version of all Spark-related dependencies here.
spark_version = '2.4.8'
// Spark 2 version as defined in BeamModulePlugin
spark_version = spark2_version
spark_scala_version = '2.11'
// Copy shared sources for Spark 2 to use Spark 3 as primary version in place
copySourceBase = true
Expand Down
6 changes: 3 additions & 3 deletions runners/spark/3/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
def basePath = '..'
/* All properties required for loading the Spark build script */
project.ext {
// Set the version of all Spark-related dependencies here.
spark_version = '3.1.2'
// Spark 3 version as defined in BeamModulePlugin
spark_version = spark3_version
spark_scala_version = '2.12'
copySourceBase = false // disabled to use Spark 3 as primary dev version
archives_base_name = 'beam-runners-spark-3'
Expand All @@ -29,7 +29,7 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/spark_runner.gradle"


// Additional supported Spark versions (used in compatibility tests)
def sparkVersions = [
"330": "3.3.0",
"321": "3.2.1"
Expand Down

0 comments on commit 1179fdc

Please sign in to comment.