Do not use 'old' OpenFF Toolkit API #545
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
A change I made to the toolkit (openforcefield/openff-toolkit#1661) involved changing how attributes are looked up, which made this check
no longer produce the same behavior as when I wrote it. With 0.14.4, released last night, this line erroneously evaluates to
True
. There would be a few ways to fix this, but I'm proposing to just remove the dual support. We are no longer supporting the "old" (< 0.11) versions of the toolkit. Note, of course, that this change wouldn't affect any released version of Foyer.I also noticed tests aren't run in parallel - it's a small and straightforward fix to get CI to use the multiple cores that GHA provides
. I'm lazy.
PR Checklist