Issue 1080 #1088
Merged
Issue 1080 #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1088 +/- ##
==========================================
- Coverage 90.64% 90.64% -0.01%
==========================================
Files 61 61
Lines 6231 6240 +9
==========================================
+ Hits 5648 5656 +8
- Misses 583 584 +1 ☔ View full report in Codecov by Sentry. |
CalCraven
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
This PR pretty much looks good, thanks for the contribution @RainierBarrett @chrisjonesBSU.
| ) | ||
| for bound in bounds: | ||
| if not isinstance(bound, (Box, list)): | ||
| raise ValueError( |
There was a problem hiding this comment.
A unit test that this error is called would be great in test_packing.py. Same for the error on line 368.
There was a problem hiding this comment.
Second this.
An example of how to invoke an error for testing with pytest:
def test_n_bonds_particle(self):
comp = mb.Compound(name="A", pos=[0, 0, 0])
with pytest.raises(MBuildError):
comp.n_bonds
* [pre-commit.ci] pre-commit autoupdate updates: - [github.com/psf/black: 22.12.0 → 23.1.0](psf/black@22.12.0...23.1.0) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Produce n=2 when ports are not capped * Add option to not scale charges in lj units, and update docs for consistency * Update mbuild/formats/lammpsdata.py Co-authored-by: Co Quach <43968221+daico007@users.noreply.github.com> --------- Co-authored-by: Co Quach <43968221+daico007@users.noreply.github.com>
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Addresses #1080. Added some more aggressive input checks around the
boundsarg forfill_region. Not sure if new unit tests are warranted but happy to add if so.PR Checklist