-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
print the hierarchy of a compound #1097
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…nd names of the particles contained by the given compound
for more information, see https://pre-commit.ci
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1097 +/- ##
==========================================
+ Coverage 89.29% 89.39% +0.10%
==========================================
Files 61 61
Lines 6173 6235 +62
==========================================
+ Hits 5512 5574 +62
Misses 661 661
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Linux tests are being reported as failing, but it appears it is actually just being canceled when testing the silica interface. Basically, same thing as discussed in #1090 . I'm going to go ahead and comment out those tests of the next commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, some comment about the identifiers (to avoid false positive)
Also, pre-commit is failing due to docstring style issues
|
marking argument as optional Co-authored-by: Co Quach <43968221+daico007@users.noreply.github.com>
marking argument as optional Co-authored-by: Co Quach <43968221+daico007@users.noreply.github.com>
marking argument as optional Co-authored-by: Co Quach <43968221+daico007@users.noreply.github.com>
for more information, see https://pre-commit.ci
…uild into plot_hierarchy
for more information, see https://pre-commit.ci
Ok, I think all comments are addressed. Read the docs is still failing because of the "unexpected" indents in some of the hoomd conversion files. Might need to do a separate PR to try to figure out why those are failing because nothing seems wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR Summary:
This refers to issue #1096 . This adds in functionality to print out the hierarchy using treelib (https://treelib.readthedocs.io/en/latest/).
An example output of a system with two ethane molecules is shown below. The function will automatically group together compounds at the same level that are identical in name, number and name of children and number and name of particles.
PR Checklist