Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle hoomd 4 #1128

Merged
merged 1 commit into from
Jun 11, 2023
Merged

handle hoomd 4 #1128

merged 1 commit into from
Jun 11, 2023

Conversation

daico007
Copy link
Member

@daico007 daico007 commented Jun 9, 2023

Address #1126, update check and handle hoomd 4 dihedral.

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.05 ⚠️

Comparison is base (7eb74c6) 87.16% compared to head (38e63c5) 87.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1128      +/-   ##
==========================================
- Coverage   87.16%   87.12%   -0.05%     
==========================================
  Files          62       62              
  Lines        6445     6448       +3     
==========================================
  Hits         5618     5618              
- Misses        827      830       +3     
Impacted Files Coverage Δ
mbuild/formats/hoomd_forcefield.py 77.17% <0.00%> (-1.28%) ⬇️
mbuild/formats/hoomd_snapshot.py 76.14% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daico007 daico007 merged commit 738bf49 into mosdef-hub:main Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant