Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct lizard command when custom executable is provided #25

Merged
merged 1 commit into from
Apr 8, 2018

Conversation

mgrebenets
Copy link
Collaborator

Min required version checks always run using lizard command, which may not even be available.
If custom executable is specified, then this executable should be used instead.

@codecov
Copy link

codecov bot commented Apr 5, 2018

Codecov Report

Merging #25 into master will increase coverage by 0.96%.
The diff coverage is 95.45%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25      +/-   ##
=======================================
+ Coverage   95.03%   96%   +0.96%     
=======================================
  Files           4     4              
  Lines         161   175      +14     
=======================================
+ Hits          153   168      +15     
+ Misses          8     7       -1
Impacted Files Coverage Δ
spec/lizard_spec.rb 100% <100%> (ø) ⬆️
...ib/fastlane/plugin/lizard/actions/lizard_action.rb 89.83% <85.71%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d108a9d...102fef4. Read the comment docs.

@mgrebenets mgrebenets force-pushed the executable-fix branch 2 times, most recently from 5d1b76b to 93463ba Compare April 7, 2018 00:58
@mgrebenets mgrebenets added the bug Something isn't working label Apr 7, 2018
Copy link
Owner

@mosesliao mosesliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! excellent work @mgrebenets. I approve the PR. you can merge it

@mgrebenets mgrebenets merged commit 3e89fb2 into mosesliao:master Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants