Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for list of languages #9

Merged
merged 1 commit into from
Mar 19, 2018

Conversation

mgrebenets
Copy link
Collaborator

Current code says "List languages", but will only use one -l flag.
This change adds simple parsing logic for comma-separated list of languages.
Ideally the FL_LIZARD_LANGUAGE option should be FL_LIZARD_LANGUAGES and take an array rather than string.
But that would be a breaking change for all current plugin users.

@mosesliao mosesliao self-requested a review March 19, 2018 02:37
Copy link
Owner

@mosesliao mosesliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. And accept my invite as a collaborator. Thanks!

@mosesliao
Copy link
Owner

mosesliao commented Mar 19, 2018

@mgrebenets you can do the merge pull request. The release of the gem I do it tonight

@mgrebenets
Copy link
Collaborator Author

Will merge, but I will add few more tests first.
I realized I haven't done that :)

@mgrebenets mgrebenets merged commit 896e119 into mosesliao:master Mar 19, 2018
@mgrebenets mgrebenets deleted the fix-languages branch March 19, 2018 03:32
@mosesliao
Copy link
Owner

@mgrebenets I release the gem. Feel free to download the plugin and use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants