[Units]fix bad length multiplier in MeterDecimal #1678
Annotations
2 errors and 27 warnings
Black (Python)
Process completed with exit code 1.
|
Cpplint
Process completed with exit code 1.
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Black (Python):
src/Mod/Draft/draftviewproviders/view_layer.py#L1
would reformat src/Mod/Draft/draftviewproviders/view_layer.py
|
Pylint:
src/Mod/Draft/draftviewproviders/view_layer.py#L32
Use 'from pivy import coin' instead (consider-using-from-import)
|
Pylint:
src/Mod/Draft/draftviewproviders/view_layer.py#L33
Use 'from PySide import QtCore' instead (consider-using-from-import)
|
Pylint:
src/Mod/Draft/draftviewproviders/view_layer.py#L34
Use 'from PySide import QtGui' instead (consider-using-from-import)
|
Pylint:
src/Mod/Draft/draftviewproviders/view_layer.py#L187
Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
|
Pylint:
src/Mod/Draft/draftviewproviders/view_layer.py#L197
Unused argument 'vobj' (unused-argument)
|
Pylint:
src/Mod/Draft/draftviewproviders/view_layer.py#L213
Unused argument 'state' (unused-argument)
|
Pylint:
src/Mod/Draft/draftviewproviders/view_layer.py#L232
Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return)
|
Pylint:
src/Mod/Draft/draftviewproviders/view_layer.py#L335
Import outside toplevel (draftmake.make_layer.get_layer_container) (import-outside-toplevel)
|
Pylint:
src/Mod/Draft/draftviewproviders/view_layer.py#L454
Unnecessary "elif" after "continue", remove the leading "el" from "elif" (no-else-continue)
|
Pylint:
src/Mod/Draft/draftviewproviders/view_layer.py#L443
Too many nested blocks (6/5) (too-many-nested-blocks)
|
Cpplint:
src/Base/UnitsSchemaMeterDecimal.cpp#L40
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
Cpplint:
src/Base/UnitsSchemaMeterDecimal.cpp#L46
Add #include <string> for string [build/include_what_you_use] [4]
|
Clazy:
src/Base/Unit.h#L64
Pass small and trivially-copyable type by value (const class Base::Unit &) [-Wclazy-function-args-by-value]
|
Clazy:
src/Base/Unit.h#L68
Pass small and trivially-copyable type by value (const class Base::Unit &) [-Wclazy-function-args-by-value]
|
Clazy:
src/Base/Unit.h#L166
Pass small and trivially-copyable type by value (const class Base::Unit &) [-Wclazy-function-args-by-value]
|
Clazy:
src/Base/Unit.h#L172
Pass small and trivially-copyable type by value (const class Base::Unit &) [-Wclazy-function-args-by-value]
|
Clazy:
src/Base/Quantity.h#L164
Pass small and trivially-copyable type by value (const struct Base::QuantityFormat &) [-Wclazy-function-args-by-value]
|
Clazy:
src/Base/Quantity.h#L187
Pass small and trivially-copyable type by value (const class Base::Unit &) [-Wclazy-function-args-by-value]
|
Clang-tidy:
src/Base/UnitsSchemaMeterDecimal.cpp#L46
7 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
Clang-tidy:
src/Base/UnitsSchemaMeterDecimal.cpp#L47
1e3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
Clang-tidy:
src/Base/UnitsSchemaMeterDecimal.cpp#L48
1e6 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
Clang-tidy:
src/Base/UnitsSchemaMeterDecimal.cpp#L49
1e9 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
Clang-tidy:
src/Base/UnitsSchemaMeterDecimal.cpp#L50
1000000 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
Clang-tidy:
src/Base/UnitsSchemaMeterDecimal.cpp#L51
1000000 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
Clang-tidy:
src/Base/UnitsSchemaMeterDecimal.cpp#L53
1e3 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
Loading