Merge pull request FreeCAD#18988 from Roy-043/Draft-Bim-Layer-manager…

…-transp-zero Draft and BIM: Layer manager did not accept zero transparency
mosfet80 · Jan 10, 2025 · 7829fcc · 7829fcc
2 parents 73f0e16 + 27ac5c4
commit 7829fcc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/src/Mod/BIM/bimcommands/BimLayers.py b/src/Mod/BIM/bimcommands/BimLayers.py
@@ -269,12 +269,11 @@ def accept(self):
 
             # transparency
             transparency = self.model.item(row, 6).data(QtCore.Qt.DisplayRole)
-            if transparency:
-                if obj.ViewObject.Transparency != transparency:
-                    if not changed:
-                        FreeCAD.ActiveDocument.openTransaction("Layers change")
-                        changed = True
-                    obj.ViewObject.Transparency = transparency
+            if obj.ViewObject.Transparency != transparency:
+                if not changed:
+                    FreeCAD.ActiveDocument.openTransaction("Layers change")
+                    changed = True
+                obj.ViewObject.Transparency = transparency
 
             # line print color
             color = self.model.item(row, 7).data(QtCore.Qt.UserRole)

diff --git a/src/Mod/Draft/draftguitools/gui_layers.py b/src/Mod/Draft/draftguitools/gui_layers.py
@@ -235,12 +235,11 @@ def accept(self):
 
             # transparency
             transparency = self.model.item(row,6).data(QtCore.Qt.DisplayRole)
-            if transparency:
-                if vobj.Transparency != transparency:
-                    if not changed:
-                        doc.openTransaction("Layers change")
-                        changed = True
-                    vobj.Transparency = transparency
+            if vobj.Transparency != transparency:
+                if not changed:
+                    doc.openTransaction("Layers change")
+                    changed = True
+                vobj.Transparency = transparency
 
             # line print color
             color = self.model.item(row,7).data(QtCore.Qt.UserRole)