-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: unite the bin cache dir for all projects in go.work #609
Merged
spacewander
merged 9 commits into
mosn:main
from
Chever-John:chore/unite-the-bin-cache-dir
Jul 2, 2024
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9c6b3ba
chore: ignore goland .idea dir
Chever-John 7131b29
chore: finish the unite the bin cache dir for controller project
Chever-John 8a1bbb3
chore: finish the unite the bin cache dir for e2e project
Chever-John f6be174
chore: update test.yml in .github
Chever-John 3edbe29
chore(makefile): use realpath to replace the $LOCALBIN var
Chever-John 53e855c
chore: update all makefile which use th e LOCALBIN var
Chever-John 3c91675
chore: update istio localbin var
Chever-John 6d5c547
chore: update site && Makefile
Chever-John 76d4771
chore: remove duplicate SHELL var
Chever-John File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -89,11 +89,11 @@ KIND ?= kind | |
##@ Build Dependencies | ||
|
||
## Location to install dependencies to | ||
LOCALBIN ?= $(shell cd .. && pwd)/bin | ||
#LOCALBIN ?= $(shell cd .. && pwd)/bin | ||
# Remember to remove tools downloaded into bin directory manually before updating them. | ||
# If they need to be updated frequently, we can consider to store them in the `Dockerfile.dev`. | ||
$(LOCALBIN): | ||
mkdir -p $(LOCALBIN) | ||
#$(LOCALBIN): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just comment out the above code temporarily. |
||
# mkdir -p $(LOCALBIN) | ||
|
||
## Tool Binaries | ||
KUBECTL ?= kubectl | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linke to #609 (comment)
Here is my solution:)
@spacewander