Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use fsnotify to detect model/policy files change in casbin plugin #614
feat: Use fsnotify to detect model/policy files change in casbin plugin #614
Changes from 37 commits
66d0cb7
fe5182e
1bfb1d4
3120753
7bf2834
d0dc175
17ed368
99bf29d
57329f4
6eb6b03
5c99c69
846ff5b
f330ec6
29822b8
a7bf59d
6719586
daf2c24
7120888
c2ffc2e
46d90e6
2b01940
c1522d2
c7cdd4a
4c686e2
cc84ebd
5e32bea
930b568
1eaa4e7
e34511d
7a1551f
bbefd66
f239cf5
75d00da
b9d7d06
0b03da5
8ca375a
363dd1d
b81b325
c879870
ac85bd9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 45 in plugins/pkg/file/fs.go
Codecov / codecov/patch
plugins/pkg/file/fs.go#L45
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a Dir call?
Check warning on line 64 in plugins/pkg/file/fs.go
Codecov / codecov/patch
plugins/pkg/file/fs.go#L64
Check warning on line 68 in plugins/pkg/file/fs.go
Codecov / codecov/patch
plugins/pkg/file/fs.go#L68
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the Op is
Chmod | SomethingElse
, the SomethingElse event will be ignored.Check warning on line 87 in plugins/pkg/file/fs.go
Codecov / codecov/patch
plugins/pkg/file/fs.go#L87
Check warning on line 94 in plugins/pkg/file/fs.go
Codecov / codecov/patch
plugins/pkg/file/fs.go#L93-L94
Check warning on line 93 in plugins/plugins/casbin/config.go
Codecov / codecov/patch
plugins/plugins/casbin/config.go#L91-L93
Check warning on line 107 in plugins/plugins/casbin/config.go
Codecov / codecov/patch
plugins/plugins/casbin/config.go#L107
Check warning on line 113 in plugins/plugins/casbin/config.go
Codecov / codecov/patch
plugins/plugins/casbin/config.go#L113