Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller-gen version to avoid incompatibility with Go version. #688

Closed
wants to merge 51 commits into from

Conversation

lyt122
Copy link
Contributor

@lyt122 lyt122 commented Aug 19, 2024

Fix #640

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 76.78571% with 13 lines in your changes missing coverage. Please review.

Project coverage is 88.24%. Comparing base (acd7184) to head (a4b6536).
Report is 21 commits behind head on main.

Files Patch % Lines
controller/registries/consul/config.go 76.78% 11 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
+ Coverage   88.16%   88.24%   +0.07%     
==========================================
  Files         119      119              
  Lines        5763     5834      +71     
==========================================
+ Hits         5081     5148      +67     
- Misses        492      496       +4     
  Partials      190      190              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lyt122 lyt122 closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the version of controller-gen
1 participant