Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support tencentcloud sms component #1001

Merged
merged 7 commits into from
Nov 8, 2023
Merged

Conversation

alilestera
Copy link
Contributor

@alilestera alilestera commented Oct 12, 2023

What this PR does:
Make Layotto support tencentcloud sms component for sms API.

Which issue(s) this PR fixes:

Not a fix, but a completion of part of the task for #830.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@github-actions
Copy link

Hi @alilestera. Thanks for your PR! 🎉
If the PR is ready, use the /cc command to assign reviewer to review.

Details

The full list of commands accepted by this bot can be found here.

The pull request process is described here.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
components/sms/tencentcloud/sms.go 97.59% <97.59%> (ø)

📢 Thoughts on this report? Let us know!.

@layotto-cla layotto-cla bot added size/XL and removed size/L labels Oct 12, 2023
@alilestera alilestera marked this pull request as ready for review October 14, 2023 07:40
@alilestera
Copy link
Contributor Author

/cc @zhenjunMa
/cc @wenxuwan

@zhenjunMa zhenjunMa closed this Oct 31, 2023
@zhenjunMa zhenjunMa reopened this Oct 31, 2023
Copy link
Contributor

@zhenjunMa zhenjunMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhenjunMa zhenjunMa closed this Nov 1, 2023
@zhenjunMa zhenjunMa reopened this Nov 1, 2023
@zhenjunMa zhenjunMa closed this Nov 1, 2023
@zhenjunMa zhenjunMa reopened this Nov 1, 2023
@zhenjunMa zhenjunMa merged commit f5a5957 into mosn:main Nov 8, 2023
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants