feat: api-plugin #358
Merged
feat: api-plugin #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #358 +/- ##
==========================================
- Coverage 57.90% 56.53% -1.38%
==========================================
Files 48 47 -1
Lines 2226 2220 -6
==========================================
- Hits 1289 1255 -34
- Misses 791 827 +36
+ Partials 146 138 -8
Continue to review full report at Codecov.
|
seeflood
requested review from
wenxuwan,
zhenjunMa,
MoonShining,
stulzq and
ZLBer
Closed
MoonShining
approved these changes
Dec 10, 2021
zhenjunMa
approved these changes
Dec 10, 2021
nobodyiam
reviewed
Dec 31, 2021
| apiForTest.AppCallbackConn = callbackClient | ||
| apiForTest.json = jsoniter.ConfigFastest | ||
| err = apiForTest.publishMessageGRPC(context.Background(), msg) | ||
| assert.Nil(t, err) |
There was a problem hiding this comment.
It seems this test is too simple that it nearly tests nothing. We need to at least test clientV1.OnTopicEvent is executed with the right input and output.
nobodyiam
reviewed
Dec 31, 2021
| ) | ||
| // 4. assert | ||
| assert.Nil(t, err) | ||
| assert.NotNil(t, server) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add api-plugin feature.
Users can add their own private grpc API based on their need.
Quickstart: docs/en/start/api_plugin/helloworld.md
Design doc: docs/zh/design/api_plugin/design.md
Which issue(s) this PR fixes:
Fixes #200
Special notes for your reviewer:
Does this PR introduce a user-facing change?: