Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add file api impl tencent cloud oss #394

Merged
merged 8 commits into from
Feb 25, 2022

Conversation

stulzq
Copy link
Member

@stulzq stulzq commented Feb 23, 2022

No description provided.

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #394 (c96040b) into main (19826f7) will increase coverage by 0.07%.
The diff coverage is 59.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
+ Coverage   56.79%   56.86%   +0.07%     
==========================================
  Files         115      116       +1     
  Lines        6089     6236     +147     
==========================================
+ Hits         3458     3546      +88     
- Misses       2280     2323      +43     
- Partials      351      367      +16     
Impacted Files Coverage Δ
components/file/s3/tencentcloud/oss.go 59.86% <59.86%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19826f7...c96040b. Read the comment docs.

@stulzq stulzq requested a review from seeflood February 24, 2022 03:21
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks okay to me.Thanks for your contribution !

Could u please add more tests to make the test coverage of oss.go higher?
I will modify the codecov configuration to ignore those of components/rpc/invoker/mosn/channel/xchannel.go and components/configstores/apollo/change_listener.go

@stulzq
Copy link
Member Author

stulzq commented Feb 24, 2022

The code looks okay to me.Thanks for your contribution !

Could u please add more tests to make the test coverage of oss.go higher? I will modify the codecov configuration to ignore those of components/rpc/invoker/mosn/channel/xchannel.go and components/configstores/apollo/change_listener.go

No problem

@stulzq stulzq requested a review from seeflood February 24, 2022 13:49
Copy link
Member

@wenxuwan wenxuwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood seeflood merged commit ca8887b into mosn:main Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants