-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add file api impl tencent cloud oss #394
Conversation
Codecov Report
@@ Coverage Diff @@
## main #394 +/- ##
==========================================
+ Coverage 56.79% 56.86% +0.07%
==========================================
Files 115 116 +1
Lines 6089 6236 +147
==========================================
+ Hits 3458 3546 +88
- Misses 2280 2323 +43
- Partials 351 367 +16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks okay to me.Thanks for your contribution !
Could u please add more tests to make the test coverage of oss.go
higher?
I will modify the codecov configuration to ignore those of components/rpc/invoker/mosn/channel/xchannel.go
and components/configstores/apollo/change_listener.go
No problem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.