Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add skywalking trace #404

Merged
merged 23 commits into from
Mar 25, 2022
Merged

feat: add skywalking trace #404

merged 23 commits into from
Mar 25, 2022

Conversation

stulzq
Copy link
Member

@stulzq stulzq commented Mar 3, 2022

What this PR does:
add skywalking tracer
Which issue(s) this PR fixes:

#310
Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@codecov
Copy link

codecov bot commented Mar 3, 2022 •
edited
Loading

Codecov Report

Merging #404 (b95b255) into main (b5514e1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #404   +/-   ##
=======================================
  Coverage   60.18%   60.18%           
=======================================
  Files         117      117           
  Lines        6252     6252           
=======================================
  Hits         3763     3763           
  Misses       2128     2128           
  Partials      361      361
Impacted Files Coverage Δ
components/trace/span.go 31.03% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5514e1...b95b255. Read the comment docs.

wenxuwan
wenxuwan previously approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@wenxuwan wenxuwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seeflood
Copy link
Member

Thanks !
I just changed the config_stores in config.json to config_store

zhenjunMa
zhenjunMa previously approved these changes Mar 18, 2022
View reviewed changes
@seeflood
Copy link
Member

Got an error when running the demo:
image
It seems that the main.go forgot to import grpcmetric package. I will help fix it

@seeflood
Copy link
Member

fixed.
Besides, I modified the document and added it to the sidebar

@stulzq stulzq requested a review from seeflood March 25, 2022 08:24
seeflood
seeflood approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for your great contribution!

@seeflood seeflood merged commit 5fd23de into mosn:main Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhenjunMa zhenjunMa zhenjunMa approved these changes

@seeflood seeflood seeflood approved these changes

@wenxuwan wenxuwan wenxuwan left review comments

@nejisama nejisama Awaiting requested review from nejisama

Assignees

@wenxuwan wenxuwan

Labels
cla:yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stulzq @seeflood @wenxuwan @zhenjunMa