Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dubbo demo fails (#458) #459

Merged
merged 3 commits into from
Apr 13, 2022
Merged

fix: dubbo demo fails (#458) #459

merged 3 commits into from
Apr 13, 2022

Conversation

rayowang
Copy link
Member

What this PR does:
fix dubbo demo
Which issue(s) this PR fixes:
Fixes #458

Special notes for your reviewer:
With this operation, I can successfully run the dubbo demo and receive the response.

Does this PR introduce a user-facing change?:

@rayowang rayowang changed the title fix dubbo demo (#458) fix dubbo demo Apr 10, 2022
@mosn-community-bot mosn-community-bot bot added bug Something isn't working cla:no labels Apr 10, 2022
@rayowang rayowang changed the title fix dubbo demo fix: dubbo demo fails (#458) Apr 10, 2022
@rayowang rayowang closed this Apr 10, 2022
@rayowang rayowang reopened this Apr 10, 2022
@codecov
Copy link

codecov bot commented Apr 10, 2022 •
edited
Loading

Codecov Report

Merging #459 (67df065) into main (fa5ebd7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #459   +/-   ##
=======================================
  Coverage   60.50%   60.50%           
=======================================
  Files         118      118           
  Lines        6357     6357           
=======================================
  Hits         3846     3846           
  Misses       2142     2142           
  Partials      369      369

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa5ebd7...67df065. Read the comment docs.

seeflood
seeflood requested changes Apr 11, 2022
View reviewed changes
docs/zh/start/rpc/dubbo_json_rpc.md Show resolved Hide resolved
docs/zh/start/rpc/dubbo_json_rpc.md Outdated Show resolved Hide resolved
@seeflood seeflood removed the cla:no label Apr 11, 2022
seeflood
seeflood requested changes Apr 11, 2022
View reviewed changes
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
Besides,could u also fix the english demo, it's same with chinese

https://mosn.io/layotto/#/en/start/rpc/dubbo_json_rpc

@rayowang
Copy link
Member Author

Thanks for your contribution! Besides,could u also fix the english demo, it's same with chinese

https://mosn.io/layotto/#/en/start/rpc/dubbo_json_rpc

ok

@seeflood seeflood mentioned this pull request Apr 11, 2022
Merged
7 tasks
seeflood
seeflood approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

docs/en/start/rpc/dubbo_json_rpc.md Show resolved Hide resolved
@seeflood seeflood merged commit 1d2bed6 into mosn:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seeflood seeflood seeflood approved these changes

@wenxuwan wenxuwan wenxuwan approved these changes

@MoonShining MoonShining Awaiting requested review from MoonShining

@stulzq stulzq Awaiting requested review from stulzq

@ZLBer ZLBer Awaiting requested review from ZLBer

Assignees
No one assigned
Labels
bug Something isn't working cla:yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dubbo demo fails
3 participants
@rayowang @wenxuwan @seeflood