Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FaaS quickstart fails #537

Merged
merged 1 commit into from
May 4, 2022
Merged

Conversation

rayowang
Copy link
Member

@rayowang rayowang commented May 3, 2022

What this PR does:
fix faas quickstart fails
Which issue(s) this PR fixes:
#520

I executed it from start to finish, except for a slight modification of the make command, everything is fine, and the final return result is as expected.
截屏2022-05-04 15 56 39

@mosn-community-bot mosn-community-bot bot added bug Something isn't working cla:yes size/XS labels May 3, 2022
@rayowang rayowang requested review from zhenjunMa and seeflood May 3, 2022 15:56
@seeflood seeflood requested a review from Xunzhuo May 3, 2022 16:00
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@JervyShi JervyShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JervyShi JervyShi merged commit cf2ce78 into mosn:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants