Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use docker-compose to start minIO and layotto #648

Merged
merged 3 commits into from
Jun 14, 2022
Merged

chore: Use docker-compose to start minIO and layotto #648

merged 3 commits into from
Jun 14, 2022

Conversation

bxiiiiii
Copy link
Contributor

What this PR does:

  • Use docker-compose to start minIO and layotto

Which issue(s) this PR fixes:

Fixes #636

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@mosn-community-bot
Copy link

Hi @bxiiiiii, welcome to mosn community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you also modify the minio quickstart doc in https://mosn.io/layotto/#/zh/start/file/minio

You can take the quickstart for state api as an example

If you don't know how to contribute to the doc, check the doc contribution guide https://mosn.io/layotto/#/zh/development/contributing-doc

@bxiiiiii
Copy link
Contributor Author

ok, let me have a try.

@bxiiiiii bxiiiiii requested a review from seeflood June 14, 2022 02:40
@bxiiiiii bxiiiiii requested a review from seeflood June 14, 2022 03:21
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #648 (1a9308d) into main (f3e0110) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #648   +/-   ##
=======================================
  Coverage   60.92%   60.92%           
=======================================
  Files         120      120           
  Lines        6377     6377           
=======================================
  Hits         3885     3885           
  Misses       2120     2120           
  Partials      372      372           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3e0110...1a9308d. Read the comment docs.

@seeflood seeflood merged commit 1576bc7 into mosn:main Jun 14, 2022
@seeflood
Copy link
Member

Thanks for your contribution and welcome to the community !

@seeflood seeflood linked an issue Jun 29, 2022 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let users run our demo without go environment use docker-compose to start minIO and layotto
3 participants