Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hello component #695

Merged
merged 37 commits into from
Jul 4, 2022
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
1e7aa37
fix: configuration API returns wrong app_id
MichaelDeSteven Jun 4, 2022
5797639
Merge branch 'main' into main
seeflood Jun 7, 2022
66a2287
Merge branch 'mosn:main' into main
MichaelDeSteven Jun 10, 2022
d6b0518
fix: configuration API returns wrong store_name
MichaelDeSteven Jun 11, 2022
d94e9ce
Merge branch 'main' into main
seeflood Jun 13, 2022
5c332da
Merge branch 'main' into main
seeflood Jun 14, 2022
0b4d4a7
Merge branch 'main' into main
seeflood Jun 14, 2022
463d37d
Update etcdv3.go
MichaelDeSteven Jun 15, 2022
2e53758
Update etcdv3_test.go
MichaelDeSteven Jun 15, 2022
533e32d
Update types.go
MichaelDeSteven Jun 15, 2022
96fa1fc
Update api_configuration.go
MichaelDeSteven Jun 15, 2022
3154441
Update types.go
MichaelDeSteven Jun 15, 2022
c46a944
Update etcdv3.go
MichaelDeSteven Jun 15, 2022
05f846c
Merge branch 'main' into main
Xunzhuo Jun 17, 2022
a35bc0b
fix: configuration API returns wrong app_id
MichaelDeSteven Jun 19, 2022
307bc23
Merge branch 'main' of https://github.com/MichaelDeSteven/layotto int…
MichaelDeSteven Jun 19, 2022
71f0837
fix: apollo configuration API returns wrong store_name
MichaelDeSteven Jun 19, 2022
23eadde
delete unused const
MichaelDeSteven Jun 19, 2022
6c6ba21
delete: redundant assign line
MichaelDeSteven Jun 20, 2022
88baba2
fix: unit test of etcdv3 subscribe
MichaelDeSteven Jun 20, 2022
df3d73f
delete: subscribereq redundant storename field
MichaelDeSteven Jun 20, 2022
00bd590
Merge branch 'main' into main
MichaelDeSteven Jun 20, 2022
1c82c02
Merge branch 'main' into main
wenxuwan Jun 21, 2022
adeac11
Merge branch 'mosn:main' into main
MichaelDeSteven Jun 21, 2022
8e1f908
refactor: replace current apollo sdk with the official one
MichaelDeSteven Jun 21, 2022
f0a7b96
refactor: replace current apollo sdk with the official one
MichaelDeSteven Jun 21, 2022
44b544e
refactor: replace current apollo sdk with the official one
MichaelDeSteven Jun 21, 2022
a77ceda
Merge branch 'main' into main
MichaelDeSteven Jun 22, 2022
5b38153
refactor: replace current apollo sdk with the official one
MichaelDeSteven Jun 22, 2022
610e407
update: go 1.17 module
MichaelDeSteven Jun 22, 2022
951ee9a
refactor: replace current apollo sdk with the official one
MichaelDeSteven Jun 22, 2022
d71cc65
refactor: replace current apollo sdk with the official one
MichaelDeSteven Jun 22, 2022
f738737
refactor: replace current apollo sdk with the official one
MichaelDeSteven Jun 22, 2022
015440b
Merge branch 'mosn:main' into main
MichaelDeSteven Jun 23, 2022
6845f6a
Merge branch 'mosn:main' into main
MichaelDeSteven Jun 24, 2022
11249a4
Merge branch 'mosn:main' into main
MichaelDeSteven Jul 3, 2022
8943192
typo: hello component field
MichaelDeSteven Jul 3, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions components/hello/registry.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@ type Registry interface {

type HelloFactory struct {
CompType string
FatcoryMethod func() HelloService
FactoryMethod func() HelloService
}

func NewHelloFactory(compType string, f func() HelloService) *HelloFactory {
return &HelloFactory{
CompType: compType,
FatcoryMethod: f,
FactoryMethod: f,
}
}

Expand All @@ -54,7 +54,7 @@ func NewRegistry(info *info.RuntimeInfo) Registry {

func (r *helloRegistry) Register(fs ...*HelloFactory) {
for _, f := range fs {
r.stores[f.CompType] = f.FatcoryMethod
r.stores[f.CompType] = f.FactoryMethod
r.info.RegisterComponent(ServiceName, f.CompType) // 注册组件信息
}
}
Expand Down