feat(oss api): support ceph oss #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fit ceph object gateway, so that we can use Layotto to store object into CEPH.
Merge remote-tracking branch 'origin/main' into dev
Codecov ReportBase: 60.39% // Head: 60.50% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #775 +/- ##
==========================================
+ Coverage 60.39% 60.50% +0.11%
==========================================
Files 133 135 +2
Lines 8398 8807 +409
==========================================
+ Hits 5072 5329 +257
- Misses 2738 2825 +87
- Partials 588 653 +65
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
wenxuwan
reviewed
Sep 4, 2022
Move components/oss/ceph/option.go, components/oss/ceph/option_test.go, components/oss/aws/option.go and components/oss/aws/option_test.go to components/oss/
wenxuwan
reviewed
Sep 21, 2022
|
please add ut case to fix the ut coverage |
ok |
seeflood
requested changes
Oct 13, 2022
|
@wlwilliamx Hi, could u add docs in some other pull request?
Reference: |
ok! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Support ceph object gateway, so that we can use Layotto to store object into CEPH.
Which issue(s) this PR fixes:
Fixes #775
Special notes for your reviewer:
Does this PR introduce a user-facing change?: