Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set deadlink validation to schedule, move out of PRs #788

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Sep 14, 2022

Signed-off-by: Xunzhuo bitliu@tencent.com

chore: set deadlink validation to schedule, move out of PRs

Signed-off-by: Xunzhuo <bitliu@tencent.com>
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 60.56% // Head: 60.56% // No change to project coverage 👍

Coverage data is based on head (ac7651c) compared to base (6e08652).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #788   +/-   ##
=======================================
  Coverage   60.56%   60.56%           
=======================================
  Files         133      133           
  Lines        8340     8340           
=======================================
  Hits         5051     5051           
  Misses       2712     2712           
  Partials      577      577           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood
Copy link
Member

@Xunzhuo By the way, how do we know if the cron job failed? Will the job notify us by sending emails or submitting an issue?

@seeflood seeflood merged commit ef60144 into mosn:main Sep 16, 2022
@Xunzhuo
Copy link
Member Author

Xunzhuo commented Sep 18, 2022

@Xunzhuo
Copy link
Member Author

Xunzhuo commented Sep 18, 2022

And I think if we choose to watch this repo, ci failed should be notified by email, but not test yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants