Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url for search is invalid due to api change #41

Closed
Thorazine opened this issue Aug 5, 2023 · 7 comments · Fixed by #43 · May be fixed by kirtan-desai/ol-geocoder#6
Closed

Url for search is invalid due to api change #41

Thorazine opened this issue Aug 5, 2023 · 7 comments · Fixed by #43 · May be fixed by kirtan-desai/ol-geocoder#6
Labels
bug Something isn't working upstream

Comments

@Thorazine
Copy link

Apparently there has been a change in the API for open street map. The result is shown when directly accessing a search url like so: https://nominatim.openstreetmap.org/search/?q=something

With their new change you are required to drop the slash like so: https://nominatim.openstreetmap.org/search?q=something

The result now is that a search will trigger a 404 with an error like: "Error! No internet connection?"

@Synchro
Copy link
Contributor

Synchro commented Aug 5, 2023

Ah, I've seen that and wondered what was going on!

@mostafaznv
Copy link
Owner

Thank you for reporting the issue. I will look into it tomorrow.

@Thorazine
Copy link
Author

There is an easy temp fix for everybody that does not use a build process in their deploy line. On your server go to the vendor/mostafaznv/nova-map-field/dist/js/field.js and search for "https://nominatim.openstreetmap.org/search/". Remove the trailing slash and your done until the next time you update this composer package. Only requires a refresh of your page, no build.

@mostafaznv
Copy link
Owner

mostafaznv commented Aug 7, 2023

Apologies for the late response. It has been a busy and long day.

I have investigated the issue and found that it is a bug in the upstream package (ol-geocoder). I have submitted a PR to address the problem, and I hope they will merge it soon.

In the meantime, I have published a temporary solution, and you can use it with the upcoming release.

@isoleenta
Copy link

Thank you so much. You helped me too)

@msabahDatac
Copy link

msabahDatac commented Sep 7, 2023

I fixed this issue by

1- this comment #41 (comment)
or
2- $: composer update mostafaznv/nova-map-field

Thanks @Thorazine

@mostafaznv mostafaznv mentioned this issue Sep 10, 2023
Merged
@mostafaznv
Copy link
Owner

fixed.
please update to 3.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants