Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #52

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Update README.md #52

merged 1 commit into from
Mar 28, 2024

Conversation

marlocorridor
Copy link
Contributor

Fix sample migration for point.

as stated on the package matanyadaev/laravel-eloquent-spatial

$table->geometry('location', subtype: 'point')->nullable();

Fix sample migration for `point`. 

as stated on the package `matanyadaev/laravel-eloquent-spatial`

```PHP
$table->geometry('location', subtype: 'point')->nullable();
```
@mostafaznv
Copy link
Owner

Hi @marlocorridor,

Thank you very much for the PR!

Could you please update the migration lines for polygon and multi-polygon?

Also, regarding the new syntax, it currently only works on L11, and for L10, we should stick to the old one.

We’ll need to mention both in the readme.

Here’s the link for reference: https://github.com/MatanYadaev/laravel-eloquent-spatial/tree/master/tests/database

@mostafaznv mostafaznv merged commit 82f3235 into mostafaznv:master Mar 28, 2024
1 check failed
@marlocorridor
Copy link
Contributor Author

@mostafaznv, I saw that you already changed the README file. Sorry for the missed opportunity to help more.

🚀 🚀 🚀
Thanks for this great package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants