Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support empty lines and comments. #404

Merged
merged 2 commits into from
Jan 16, 2022
Merged

Support empty lines and comments. #404

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e918cf3
Support empty lines and comments.
wffranco Jun 18, 2019
4b956d4
Merge branch 'master' into patch-3
motdotla Jan 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ function parse (src /*: string | Buffer */, options /*: ?DotenvParseOptions */)

// convert Buffers before splitting into lines and processing
src.toString().split(NEWLINE).forEach(function (line, idx) {
line = line.trim()
// ignore empty and commented lines
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want to influence "debug" behavior, I'd suggest moving closer there instead of possibly altering the parsing logic. if (debug && line.length && line[0] !== '#') might do it, although I have reservations about decreasing debug output.

if (line === '' || line[0] === '#') {
return
}
// matching "KEY' and 'VAL' in 'KEY=VAL'
const keyValueArr = line.match(RE_INI_KEY_VAL)
// matched?
Expand Down